Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: plan cache supports Batch/PointGet converted from (primary keys) in ((...), ...) #47198

Merged
merged 2 commits into from
Sep 22, 2023
Merged

planner: plan cache supports Batch/PointGet converted from (primary keys) in ((...), ...) #47198

merged 2 commits into from
Sep 22, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 22, 2023

What problem does this PR solve?

Issue Number: close #44830

Problem Summary: planner: plan cache supports Batch/PointGet converted from (primary keys) in ((...), ...)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 requested a review from a team as a code owner September 22, 2023 06:43
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2023
@tiprow
Copy link

tiprow bot commented Sep 22, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 22, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-22 06:48:02.210588589 +0000 UTC m=+845648.178176641: ☑️ agreed by AilinKid.
  • 2023-09-22 06:49:45.917973709 +0000 UTC m=+845751.885561762: ☑️ agreed by hawkingrei.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 22, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Sep 22, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1-20230818-v7.1.1@0dcd3d1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             release-7.1-20230818-v7.1.1     #47198   +/-   ##
================================================================
  Coverage                               ?   73.4371%           
================================================================
  Files                                  ?       1202           
  Lines                                  ?     376308           
  Branches                               ?          0           
================================================================
  Hits                                   ?     276350           
  Misses                                 ?      82303           
  Partials                               ?      17655

@ti-chi-bot ti-chi-bot bot merged commit a073464 into pingcap:release-7.1-20230818-v7.1.1 Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qw4990 @hawkingrei @AilinKid